search

mantoni / mochify.js

☕️ TDD with Browserify, Mocha, Headless Chrome and WebDriver
MIT License
346 stars 57 forks source link

Rewrite: Puppeteer settings #245

Closed mantoni closed 2 years ago

mantoni commented 3 years ago

Following up on #243, we need to allow custom chrome binaries and custom puppeteer settings.

We could provide sensible default settings for the testing scenario and then allow users to override those settings with any options they want.

For the custom chrome binary, this was the previous implementation:

  if (opts.chrome) {
    options.executablePath = opts.chrome;
  } else if (process.env.PUPPETEER_EXECUTABLE_PATH) {
    // Workaround for https://github.com/puppeteer/puppeteer/issues/6957
    options.executablePath = process.env.PUPPETEER_EXECUTABLE_PATH;
  }
m90 commented 2 years ago

I can take care of this this week (as if affects me too).