Import fs/promises in a way that is compatible with Node 12 still

mantoni / mochify.js

☕️ TDD with Browserify, Mocha, Headless Chrome and WebDriver

MIT License

346 stars 57 forks source link

Import fs/promises in a way that is compatible with Node 12 still #257

Closed m90 closed 2 years ago

m90 commented 2 years ago

From what I understand we still support Node 12 where importing fs/promises fails and needs to be require('fs').promises instead. See: https://nodejs.org/api/fs.html#fs_promises_api

Alternatively we could of course also drop support for 12 for the rewrite, but then again I really hope we can get this shipped before its EOL (which is end of April 2022).

mantoni commented 2 years ago

Can you add node 12.x to the build matrix?

m90 commented 2 years ago

Can you add node 12.x to the build matrix?

Done so, passes as well.