search

mantoni / mochify.js

☕️ TDD with Browserify, Mocha, Headless Chrome and WebDriver
MIT License
346 stars 57 forks source link

Shutdown on errors #260

Closed mantoni closed 2 years ago

mantoni commented 2 years ago

This is an alternative implementation of #259 which retains parallel execution of the driver and the bundler. These are the two sub processes that may take a while, so I would prefer to not run them sequentially.

One of the integration tests highlighted that the driver-jsdom doesn't return a promise, which this fixes as well.

m90 commented 2 years ago

Ah yeah, I just added a comment about how I tried this approach before but didn't like it :)

You're totally right about how both bundling and launching browser automation can be a time consuming task so let's do it like this even if it makes the code a little more complicated.

mantoni commented 2 years ago

I made new patch releases for @mochify/mochify and @mochify/driver-jsdom.