mantou132 / Spotify-Lyrics

🎉 Desktop Spotify Web Player Instant Synchronised Lyrics
https://microsoftedge.microsoft.com/addons/detail/spotify-lyrics/aiehldpoaeaidnljjimhbojpblkbembm
884 stars 60 forks source link

Enhancement regarding lyrics sourcing #25

Closed derkanadier closed 4 months ago

derkanadier commented 4 years ago

Hey @mantou132 , loving this extension so I really appreciate your time spent developing it!

I noticed that many songs in my playlists are correctly identified by your extension but no lyrics are displayed (especially regarding less popular songs). However, I also noticed that most of these have lyrics available on www.genius.com Hence, do you think it would be possible to integrate lyrics sourcing from that website?

I'd be glad to be of any help if necessary :)

mantou132 commented 4 years ago

Genius lyrics don’t seem to have a timestamp, so it ’s impossible to make synchronized lyrics.

Do you have a way to get time-stamped lyrics?

derkanadier commented 4 years ago

I see how that can be an issue. I'll look into that.

However, even if we have no timestamps from them, I thought it would still be useful for a user to see those lyrics instead of a blank album picture. In other words, having manually scrollable lyrics fetched from genius in case they aren't found from other sources with timestamps might be a nice feature to have.

mantou132 commented 4 years ago

The lyrics are displayed in the Picture-in-Picture window, and the Picture-in-Picture window is actually the video being played, that is, the user cannot manually scroll the lyrics in this window.

Unless the lyrics are displayed elsewhere

derkanadier commented 4 years ago

Oh, alright. So if I understand correctly, the only content that can be displayed in a PIP window is a video?

mantou132 commented 4 years ago

I find the only available is https://developer.musixmatch.com/documentation/api-reference/track-subtitle-get

but not for free

derkanadier commented 4 years ago

I find the only available is https://developer.musixmatch.com/documentation/api-reference/track-subtitle-get

but not for free

Oh that's unfortunate :/

DarthAV commented 3 years ago

I find the only available is https://developer.musixmatch.com/documentation/api-reference/track-subtitle-get

but not for free

Honestly not sure if this will work for a web extension, but spicetify is able to fetch Musixmatch lyrics for free for the desktop app by using free private tokens on a per-user basis. You can take a look at the steps here: https://github.com/khanhas/genius-spicetify#musicxmatch

mantou132 commented 4 months ago

V1.6.2 support spotify built-in lyrics, power by musixmatch

oRevived commented 2 months ago

Thoughts on adding LRCLIB as an alternative lyrics provider? I've had a much higher success rate of getting lyrics from there instead of Netease's API. Not asking to get rid of Netease's API but having LRCLIB as an another option would be great as in my experience it has a much bigger library of lyrics than Netease and the quality is much better too. Perhaps the extension could check for lyrics from LRCLIB first, then NeteaseCloudMusicApi, and then Google Cloud Functions?

Edit: Added in v1.6.7. Thanks!