mantou132 / Spotify-Lyrics

🎉 Desktop Spotify Web Player Instant Synchronised Lyrics
https://microsoftedge.microsoft.com/addons/detail/spotify-lyrics/aiehldpoaeaidnljjimhbojpblkbembm
859 stars 56 forks source link

Support other web player #35

Open mantou132 opened 4 years ago

mantou132 commented 4 years ago

If there are other excellent Web Players(PWA), the extension can also be adapted.

// Also need a suitable name, e.g: lyrics widget

Ways to support other players:

  1. edit manifest.json content_scripts
  2. edit config.ts currentPlatform and localConfig
  3. edit config.json

screenshot3 copy

homamgamer commented 3 years ago

youtube.com?

mantou132 commented 3 years ago

@homamgamer This extension uses the song name and artist to search for lyrics. It is foreseeable that YouTube’s lyrics match rate will be low

In other words, this extension is only suitable for music players

homamgamer commented 3 years ago

you can still figure out a way around it, you just have to work harder

homamgamer commented 3 years ago

for example, you have this addon that can look for lyrics for youtube videos I've used it and it works well but it searches for lyrics from different providers also take a look at this This

MFRehan commented 3 years ago

Hi @mantou132 , Thank for this great extension, I think It would be nice if you add support for Deezer too.

mantou132 commented 3 years ago

@MFRehan It seems to be easy to support, but only Deezer Premium can play a full-length track

Annotation 2020-08-29 114656

mantou132 commented 3 years ago

@MFRehan v1.5 should support Deezer, but currently I only test it under a free account.

And will remove the native lyrics feature

Screenshot 2020-09-12 065123

MFRehan commented 3 years ago

@mantou132 Great, Thank you for the great effort!

lostfilm commented 3 years ago

Support https://listen.tidal.com/ please.

mantou132 commented 3 years ago

@lostfilm It seems that Tidal is a very suitable webapp. But it cannot be used in my area, so I cannot log in to debug.

Louissenny commented 3 years ago

@mantou132 As a tidal user, I will be happy if I can help you test it. 😉

skeletclique commented 3 years ago

also it would be perfect for apple music web

mantou132 commented 3 years ago

@Louissenny v1.5.10 support TIDAL, But I don’t have a complete test, there may be a bug.

mantou132 commented 3 years ago

@dimivell Apple music is a very good service, but their web client is really bad, I will consider it again in the future

Louissenny commented 3 years ago

@mantou132 thanks a lot! I will check it out later and tell you if there's any bugs. Once again thank you for your work!

skeletclique commented 3 years ago

@mantou132 thank you for the consideration i think it would satisfy a lot of apple products owners who have windows laptops and can't listen to apple music (itunes has been discontinued and it lags a lot)

Louissenny commented 3 years ago

@mantou132 Hey, I've been using it for couple hours, here are some feedbacks:

For TIDAL: It works on both Chrome and Edge, fails to work on Chrome Dev due to unknown reasons (Maybe Chrome Dev has some limitations). And there's a bug: every time when a song is ended and the next song kicks in, the lyrics stuck on the end of the last song and becomes irresponsive, even if I click other songs it stays the same. This happens on both PIP and page mode, only gets back to normal if I refresh the webapp. It won't happen if I manually skip a song or select a song everytime.

For YouTube Music: As long as the extension is on the webpage goes dark, happens on Chrome, Chrome Dev and Edge, as you can see from the picture below. After I switched the extension off it gets back to normal. I've tried with different network conditions and it's all the same. I guess YouTube has some sort of detecting methods. image

Again I want to shout out to your wonderful work in such a short amount of time 👍 your extension really is the best of its kind (at least for TIDAL users, lol) thank you so much

mantou132 commented 3 years ago

@Louissenny Thank you for the test. I can’t log in to TIDAL and YouTube Music right now, so these issues cannot be fixed yet.

Louissenny commented 3 years ago

@mantou132 No problem. Please take your time ; )

mantou132 commented 3 years ago

@Louissenny I just released v1.5.12 and v1.5.13, trying to fix the bugs of YouTube music and tidal respectively

Louissenny commented 3 years ago

@mantou132 thanks for the work, seems like you stayed up late last night. I tried both versions on Chrome and Edge, and unfortunately the problem with TIDAL is still there. The lyrics won't switch to the next song automatically and stays irresponsive. And there seems to be a new bug: the album cover fails to load now, happens under several network conditions: (with extension)

with

(without extension, under the same network)

without

As for YouTube Music, it works now but face a similar problem with TIDAL, when the song automatically switches to next one the lyrics becomes unsynchronized with the song or stops showing. It won't happen when I manually select or switch the song. I guess this is due to either songs on YTM has different duration (esp. for those with a music video) or YTM has a weird setting: it won't wait until a song is fully ended and switches early.

P.S.: If you want I can give you my TIDAL and YTM accounts for you to debug, feel free to ask me, it's not a big deal ; )

mantou132 commented 3 years ago

@dimivell I tried to add lyrics to apple music, but apple music has strict restrictions and cannot access the lyrics server. I haven't found a way to break through the restrictions.

skeletclique commented 3 years ago

@mantou132 i understand thank you very much for trying i hope they make it easier at some point

skeletclique commented 3 years ago

hey @mantou132 there is this webplayer that is alternative to apple music web player.. https://musi.sh/ could the extension work for this website? it has its own lyrics but i prefer your extension

mantou132 commented 3 years ago

@skeletclique v1.5.14 support apple music.

skeletclique commented 3 years ago

@mantou132 works great although pause and play buttons dont work as sometimes lyrics and cover don't load too

iamlawy14 commented 3 years ago

@mantou132 support https://nhaccuatui.com and https://beta.nhaccuatui.com please