search

mantou132 / Spotify-Lyrics

🎉 Desktop Spotify Web Player Instant Synchronised Lyrics
https://microsoftedge.microsoft.com/addons/detail/spotify-lyrics/aiehldpoaeaidnljjimhbojpblkbembm
842 stars 52 forks source link

spotify web hotkeys and spotify lyrics extensions not working properly together (sometimes) #94

Closed TheWondaBoi closed 2 years ago

TheWondaBoi commented 2 years ago

Hello , im using spotify web hotkey extension and spotify lyrics extension

sometimes because of the song name Lenghth(this is my assumption) the hotkey of liking the running song which is the heart icon doesn't like the song but instead it toggles the spotify lyrics pip and then i have to like the song by going to the tab and clicking on heart (this happens because the spotify web hotkey extension relies on the HTML/CSS structure of the website which is the only way for extension to work)

what i request from u guys is ability to have your spotify lyrics icon to the right side of the website instead of having it next to the heart (like) icon in the left side because the spotify web hotkey extension has no issues if i got ur lyrics extension disabled and both of these extensions combined is such a usefull thing and i appreciate you guys making the lyrics extension and more importantly how im able to have small pip with realtime lyrics

would be really appreciated if u take a look into that and try the extensions together yourself so u get better explaination of what i mentioned edit : i tried this on chrome , brave and edge , same problem

mantou132 commented 2 years ago
Screen Shot 2022-06-11 at 02 41 38

There are conflicts when you use what shortcut keys? Have you ever tried to modify Lyrics Shortcut?

Right-click to open the modal

TheWondaBoi commented 2 years ago
Screen Shot 2022-06-11 at 02 41 38

There are conflicts when you use what shortcut keys? Have you ever tried to modify Lyrics Shortcut?

Right-click to open the modal

when i try to like a song using the like hotkey in spotify web hotkeys , instead of liking the music it keeps toggling the spotify lyrics pip on and off

mantou132 commented 2 years ago

make a record: https://github.com/mantou132/Spotify-Lyrics/blob/master/src/page/btn.ts#L71

In order to keep the Lyrics button as the same style as the Like button, the lyrics button copy the attribute of the Like button

zopieux commented 2 years ago

Hi, Spotify Hotkey extension's author here. It's indeed most likely the attribute copying feature that confuses the selectors I use: https://github.com/mantou132/Spotify-Lyrics/blob/f96ff16d3ac2d5049986204125144f013b65ef76/src/page/config.json#L12 versus https://github.com/zopieux/spotify-hotkeys/blob/6e5c697c47be0ba44846522300a2257441db5893/src/background.js#L23

I would suggest a simple workaround where your extension adds an extra class name to your button that I can negatively match against. Would that work?

mantou132 commented 2 years ago

@zopieux hi,

In addition to supporting Spotify, this extension also supports other music players, so to create a style of the same buttons, copying the Like button is the simplest. This is why I did not solve this problem in time.

Lyrics button add extension-lyrics-button class name and aria-label="Lyrics" attribute, you should be able to avoid selecting the lyrics button.

thanks.

zopieux commented 2 years ago

Thanks, will try that and report back.

zopieux commented 2 years ago

Version 1.0.0 has already hit the Chrome Store. @TheWondaBoi, please update then check this is fixed and report back!

TheWondaBoi commented 2 years ago

i've been checking it for over 4 hours by now and it is fixed and the 2 extensions now are working together with no problems , im very thankfull to u guys for discussing it out and for you working on this fix on your side , really appreciated. as i said these 2 extensions together are great and has no alternative.