search

mantrajs / mantra-cli

Command line interface for building Meteor apps with Mantra
MIT License
135 stars 34 forks source link

Halt create command if in root of meteor project #103

Closed thancock20 closed 7 years ago

thancock20 commented 7 years ago

As discussed in #63.

thancock20 commented 7 years ago

So, apparently the tests fail on node v0.12.10, although they pass on node v4.0.0 "undefined is not a function" Did fs.existsSync not exist yet in v0.12.10?

Never mind, there's a checkFileExists function in the utils file. I should have used that in the first place.

thancock20 commented 7 years ago

Switching to checkFileExists didn't fix the failures on v0.12.10 Not sure why it's failing there. I'll have to come back to it later.

sungwoncho commented 7 years ago

My hunch is that there is nothing wrong with this PR, but this line is failing. Maybe Object.assign was not implemented in 0.12.

I'll look into it on the weekends.

sungwoncho commented 7 years ago

by the way, looking at the Travis log, I cannot pinpoint the exact line where the error occurred because there is no source map. The stack trace points to files under /dist which is compiled and garbled.

If we can fix this, it will come in handy in the future when debugging. Any ideas?

sungwoncho commented 7 years ago

Thanks. Fixed the test in https://github.com/mantrajs/mantra-cli/commit/09ba433d9f7be6578c5347e8f96702f924714c46