Closed macrozone closed 7 years ago
left a comment. open to suggestions.
@sungwoncho ok changed it!
It seems that test is failing. Please see https://travis-ci.org/mantrajs/mantra-cli/jobs/199922989#L2937-L2956. Maybe something broke in this branch.
ok tests are fixed. also added cases for the new configs
@sungwoncho can you take a look?
LGTM. You can merge and publish. Don't forget to update https://github.com/mantrajs/mantra-cli/blob/master/RELEASE_NOTE.md. Thanks for your work.
I will do the release, but i can't merge here ;-)
ok release is done, but i can't add a release tag here
@macrozone I thought we were both admins to this repo. Could you check https://github.com/mantrajs/mantra-cli/invitations?
Merged and tagged the release.
Thanks for your hard work. Please check your admin invitation.
fixes https://github.com/mantrajs/mantra-cli/issues/111
sorry, there is no test yet for this feature ;-) (so ironic)