search

mantrajs / mantra-cli

Command line interface for building Meteor apps with Mantra
MIT License
135 stars 34 forks source link

Feature/make tests optional #112

Closed macrozone closed 7 years ago

macrozone commented 7 years ago

fixes https://github.com/mantrajs/mantra-cli/issues/111

sorry, there is no test yet for this feature ;-) (so ironic)

sungwoncho commented 7 years ago

left a comment. open to suggestions.

macrozone commented 7 years ago

@sungwoncho ok changed it!

sungwoncho commented 7 years ago

It seems that test is failing. Please see https://travis-ci.org/mantrajs/mantra-cli/jobs/199922989#L2937-L2956. Maybe something broke in this branch.

macrozone commented 7 years ago

ok tests are fixed. also added cases for the new configs

macrozone commented 7 years ago

@sungwoncho can you take a look?

sungwoncho commented 7 years ago

LGTM. You can merge and publish. Don't forget to update https://github.com/mantrajs/mantra-cli/blob/master/RELEASE_NOTE.md. Thanks for your work.

macrozone commented 7 years ago

I will do the release, but i can't merge here ;-)

macrozone commented 7 years ago

ok release is done, but i can't add a release tag here

sungwoncho commented 7 years ago

@macrozone I thought we were both admins to this repo. Could you check https://github.com/mantrajs/mantra-cli/invitations?

sungwoncho commented 7 years ago

Merged and tagged the release.

Thanks for your hard work. Please check your admin invitation.