skip creation of routes

mantrajs / mantra-cli

Command line interface for building Meteor apps with Mantra

MIT License

135 stars 34 forks source link

skip creation of routes #114

Open macrozone opened 7 years ago

macrozone commented 7 years ago

I usually only use routes in core, because having routes in multiple modules may lead to re-renderings (see https://github.com/mantrajs/mantra-core/issues/9), so it would be cool to just be able to disable route generation in other modules than core (maybe via setting)

sungwoncho commented 7 years ago

That's fair. Do you have plans for how to implement it?

macrozone commented 7 years ago

hmm...

[ ] config createRoutesOnModules: true/false
[ ] do not create route file when createRoutesOnModules is false (if its not core module, i think we should always create it)
[ ] verfiy that the module index file does not import the route file when createRoutesOnModules is false

sungwoncho commented 7 years ago

that makes sense. Feel free to open a PR and I will review it before we release.

StorytellerCZ commented 7 years ago

This would also help with React-router as routes for rr are only in core.