mantrajs / mantra-cli

Command line interface for building Meteor apps with Mantra
MIT License
135 stars 34 forks source link

Use the new storybooks/react package when generating a new project #121

Open vladejs opened 7 years ago

vladejs commented 7 years ago

Storybooks is now led by the community, and packages has changed from @kadira/storybook to @storybooks/react.

Allow mantra-cli generate correct configurations of the new Storybooks when scaffolding a new project

https://storybook.js.org/

macrozone commented 6 years ago

@vladejs I think it would be better to remove the functionality of mantra-cli to create new projects altogether and focus more on generating new entities.

vladejs commented 6 years ago

Sorry @macrozone , Don't understand what you mean.

macrozone commented 6 years ago

@vladejs The issue that you are describing is only valid when creating new projects.. mantra-cli can be used to create new (meteor) projects, but its hard to maintain that functionality.

on the other hand, on existing apps you can use mantra-cli even without meteor (e.g. with react-native) and with newer versions of storybook

to add storybook to a new project, there is a command line util from storybook. So i think its best to not use mantra-cli for creating new projects, but instead rely on existing tools.

That's why i want to focus on improving mantra-cli to work on existing apps and support different flavors (meteor with react, react without meteor, react-native, etc.)

vladejs commented 6 years ago

Thanks for your detailed explanation @macrozone , I understood.

In other topic. do you know any CRUD solution built with mantra specific to React and Meteor apps? I'm looking for some standard functionalities:

It would be great to have generic modules that creates cruds using modern libraries lilke uniforms