Closed bright-sea closed 8 years ago
Sure, sounds good to me. I thought mantra 0.2 was already being used, I thought it was basically the new module API, i.e. const app = createApp(context); app.loadModule(coreModule); ...
So what exactly are other changes? If you want to make this change, you could do it. Let me know if you want me to add you to the team.
I follow new mantra-sample-blog-app structure to make all changes, please see all changes at my fork of mantra-dialogue
Here a brief description of all changes:
With these changes, we can have a better start point to do further developments and better follow mantra changes.
Great. I took a look, I didn't realize there were so many new changes in 0.2
Since there are quite a few number of changes, any chance you could submit a PR? Unfortunately I'm late in the game when it comes to learning Git, I don't even know how to merge these changes into main repo. But I imagine a PR is the simplest way.
Or better -- I also just added you as a collaborator, so you are free to commit these changes to the main repo.
Thanks @vonwao
I just created a PR and merge it into main repo.
Do you have a plan to refactor all existing code to follow mantra 0.2.0 first?
Maybe @markoshust had already done some works on this but not checked into meteor-mantra-kickstarter yet.
There are some issues like issue#7 which stops us from upgrade meteor 1.3 beta to 6/7/8. But if we follow mantra 0.2.0 spec and the structure like mantra-sample-blog-app , this issue will gone.
So my suggestion is that we refactor current code first.