search

mantrajs / mantra-sample-blog-app

A sample blog app built with Mantra
http://mantra-sample-blog-app.herokuapp.com/
MIT License
296 stars 104 forks source link

Rename wallaby.js to .wallaby.js - remove it from Meteor build #51

Closed ShockiTV closed 8 years ago

ShockiTV commented 8 years ago

Removing wallaby.js from Meteor build path. It is messing with other stuff, for example React's dangerousStyleValue.js test for isNaN value.

Exception from Tracker recompute function:
debug.js:41 TypeError: isNaN is not a function
    at dangerousStyleValue (dangerousStyleValue.js:44)

So for example inline styles are doomed. You can check by hitting add new post without title or body - error should be shown, but inline style crash recomputation

arunoda commented 8 years ago

Is this going to help it rather renaming the file? See: https://gist.github.com/arunoda/b618f2cc9589b20ea4eb

arunoda commented 8 years ago

I made another fix to this with: https://github.com/mantrajs/mantra-sample-blog-app/commit/d9d1958814454566d72cb515b1faedc05c9c53b4

Thanks.