search

mantrajs / mantra-sample-blog-app

A sample blog app built with Mantra
http://mantra-sample-blog-app.herokuapp.com/
MIT License
296 stars 104 forks source link

Wallaby broken by commit: 'Move all .jsx to .js' #89

Closed smeijer closed 8 years ago

smeijer commented 8 years ago

As the title is saying; commit 5064335ede54e4f16caec1de730567f085f6c3c2 broke wallaby. It cannot find modules any longer. That means, wherever you depend on an 'jsx' file, and import it by import X from '../components/main_layout', you'll get an error that it cannot find the module.

arunoda commented 8 years ago

Try now. fixed it.

smeijer commented 8 years ago

No idea why it did not work when I tried that. Fixed indeed.

Unrelated to this issue, but do you have any idea if it is possible to make testrunners work with meteor package imports? Like the one below?

import { Template } from 'meteor/templating';

They all seem to break, with the message: "Error: Cannot find module 'meteor/templating'" or "Error: Cannot find module 'meteor/anti:i18n'".

arunoda commented 8 years ago

You should only import these things inside the context. We run tests outside of Meteor.