mantrajs / meteor-mantra-kickstarter

Kickstart your meteor mantra development
MIT License
184 stars 50 forks source link

use jquery npm instead of meteor/jquery #33

Open sandervanhooft opened 8 years ago

sandervanhooft commented 8 years ago

Hi,

I'd suggest to include jQuery from npm instead of using the meteor package. I see it's now included by default in the meteor package list.

If I want to adhere to the 'pure' Mantra specs, I should now do:

import { Meteor } from 'meteor';
import { jQuery } from 'meteor/jquery';

I think the preferred Mantra way would be:

import { jQuery } from 'jquery';

I have not been able to test this yet. But I think this approach is much cleaner for isolated component development/testing.

Kind regards,

Sander

TeemoWan commented 8 years ago

+1

TeemoWan commented 8 years ago

when use storybook, it can't import jquery from 'meteor/jquery'

makstr commented 8 years ago

@sandervanhooft thanks, will update the import statement in the new version

TeemoWan commented 8 years ago

https://github.com/meteor/meteor/issues/6626