search

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
94 stars 37 forks source link

unify frontend and backend server files #104

Open manu-chroma opened 6 years ago

manu-chroma commented 6 years ago

Creating separate files for serving frontend templates and separate backend server file was an inital design decision with no strong consideration apart from being easy to reason about as a beginner python programmer myself.

This decision has potential drawback such as I need to deploy two separate projects on heroku since free tier does not support more than one running proces. Thus it makes sense to unify both these files and serve them through single flask serve process.

Also, we can create append /api/ path in the url for the calls that frontend templates make to retrive the status.

cc: @jayvdb, @seeeturtle

jayvdb commented 6 years ago

Will existing api users be broken?

Other than that, i dont see reason to not unify.

The unified app could be run in api-only mode by adding a command line flag, if anyone really needed that.

manu-chroma commented 5 years ago

i don't think anyone else uses the API best to my knowledge.

I think it would be a good idea to complete this. Then i can automate the heroku deployment process for every master successful merge and build.