search

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
94 stars 37 forks source link

Add functionality to specify custom icons #114

Closed kx-chen closed 5 years ago

kx-chen commented 5 years ago

Add functionality to specify custom icons, either from an image or class, based on values set in websites.yml

Closes https://github.com/manu-chroma/username-availability-checker/issues/110

In the websites.yml file, people can now specify if they would like an image or a class to be used for the icon of a website. Keybase's was added as an example. By specifying src : ... it will construct an image tag, and by specifying class: ... it will construct an i tag.

This code desperately needs a second pair of eyes to look at it and suggest feedback!

ksdme commented 5 years ago

I am not sure if this repo follows any commit guidelines, but your commit message looks awfully long. Consider breaking it into two lines, 80 is a good character limit for a single line.