search

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
94 stars 37 forks source link

Move Javascript in status.html to separate file #131

Closed jakethakur closed 2 years ago

jakethakur commented 5 years ago

Moves the javascript in status.html to a new status.js file.

Closes #123

manu-chroma commented 5 years ago

Hey Jake. You can click on detail to check the build log for travis for your particular PR. Check it out here: https://travis-ci.org/manu-chroma/username-availability-checker/builds/449037018?utm_source=github_status&utm_medium=notification for the current failing build.

Also, try testing your changes locally. That might help you in knowing what might have gone wrong (apart from the logs)

jakethakur commented 5 years ago

OK, I believe it was just that I left some trailing whitespace (though the log is fairly verbose so I might have missed something else further down).

manu-chroma commented 5 years ago

I kind of agree. The log went just too verbose on failure. Some of the initial stuff was not very useful as such. Maybe we can do something about that later.

jakethakur commented 5 years ago

Great, thank you for your help!

manu-chroma commented 5 years ago

I will let someone else have a look too, before I merge this one!

jakethakur commented 5 years ago

OK, that should have fixed it :)

manu-chroma commented 5 years ago

We have to consider something like this: https://stackoverflow.com/questions/37259740/passing-variables-from-flask-to-javascript/37260465

or maybe a better solution for js file to have that config.

kx-chen commented 5 years ago

I've got a solution that's similiar to @manu-chroma 's suggestion. Can submit PR if you'd like. My thoughts are that it should be addressed in a different issue/pr, as it is a bit out of the scope of this task.

ghost commented 5 years ago

how to answer this question? im new