search

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
94 stars 37 forks source link

Move requests_toolbelt to requirements.txt #132

Open manu-chroma opened 5 years ago

manu-chroma commented 5 years ago

Since it is not a test requirement and is actually used in the username_api source:

https://github.com/manu-chroma/username-availability-checker/blob/master/username_api.py#L8

seeeturtle commented 5 years ago

@manu-chroma, the reason i did like that is because the result of it is actually used in test, not the server. you can know that from travis file.

manu-chroma commented 5 years ago

but you cannot run the server without installing test requirements. That's why it should be moved into main requirements

seeeturtle commented 5 years ago

Then I think it should be only used when testing, not putting in requirements.txt