search

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
96 stars 36 forks source link

templates/form.html: Add Github fork me ribbon #138

Closed Chirag0111 closed 5 years ago

Chirag0111 commented 6 years ago

This PR adds a Github fork me ribbon in form.html.

Closes https://github.com/manu-chroma/username-availability-checker/issues/126

manu-chroma commented 6 years ago

this is duplicated code from status.html

We can avoid duplicating by refactoring github icon css into main css file.

Chirag0111 commented 6 years ago

@utkarsh2102, I have done the work.

Please check the same.

manu-chroma commented 5 years ago

Hi, The changes look good to me. @utkarsh2102 the hover effect is working for me perfectly fine locally.

@Chirag0111 I've merged master into your branch and made some linting changes Can you allow me to push to your remote branch? Refer: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

utkarsh2102 commented 5 years ago

Oh, that's awesome. I will ask him to do so and would approve the task once he submits the same.

Chirag0111 commented 5 years ago

Done.

image

utkarsh2102 commented 5 years ago

Okay, nice. Approving your work.

manu-chroma commented 5 years ago

:tada: