manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
96 stars 37 forks source link

.coafile: Integrate coala for code linting #27

Closed ashwini0529 closed 6 years ago

ashwini0529 commented 6 years ago

Closes https://github.com/manu-chroma/username-availability-checker/issues/26 Also fixes linting errors using coala

manu-chroma commented 6 years ago

@ashwini0529 can you checkout master and redo the linting fixes?

manu-chroma commented 6 years ago

We should add these bears as well:

[all.python]
language = Python
bears = QuotesBear
preferred_quotation = '
default_actions = *: ApplyPatchAction

[html]
files = templates/*.html
bears = HTMLLintBear
htmllint_ignore = optional

[yaml]
files = *.yml
bears = YAMLLintBear
manu-chroma commented 6 years ago

For this PR, we can just keep it to adding .coafile. There is a lot going on already.

We can introduce coala patches when no gci student is working on tasks and preferably in separate commits.

manu-chroma commented 6 years ago

ping @ashwini0529

ashwini0529 commented 6 years ago

Just updating the PR 😄

manu-chroma commented 6 years ago

@ashwini0529 as mentioned before, please remove the coala patches from this PR. Also, you're having two commits. Please squash.

ashwini0529 commented 6 years ago

@manu-chroma done 😄

manu-chroma commented 6 years ago

Thanks @ashwini0529