search

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
96 stars 37 forks source link

Add more test parameterisation #36

Closed jayvdb closed 6 years ago

jayvdb commented 6 years ago

https://github.com/manu-chroma/username-availability-checker/pull/32 added pytest , however the test module still has lots of duplicated logic.

There are many advanced pytest data plugins which allow more data parameterisation that the core pytest plugins.

Implement one which removes the duplication in the test module.

jayvdb commented 6 years ago

... which would have prevented copy/paste errors like https://github.com/manu-chroma/username-availability-checker/pull/34#discussion_r157597839 ;-)

jayvdb commented 6 years ago

The infrastructure was already added in #42, so this is now a moderately easy task, of re-applying the same approaches used there.

seeeturtle commented 6 years ago

can you assign me here?

manu-chroma commented 6 years ago

assigned to @seeeturtle

Make sure to get your other PR merged soon.