search

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
96 stars 37 forks source link

Add Gravatar support #37

Closed jayvdb closed 5 years ago

jayvdb commented 6 years ago

Gravatar supports profile usernames.

seeeturtle commented 6 years ago

this issue is related with getting profile image of openhub since it set profile image as gravatar.

pavi2410 commented 6 years ago

I can do this. I claimed this task on GCI.

jayvdb commented 6 years ago

@pavi2410 , great, come onto https://coala.zulipchat.com/#narrow/stream/gci/subject/username-availability if you need a hand

pavi2410 commented 6 years ago

Is it OK if I parse the user page to get avatar image?

jayvdb commented 6 years ago

It is ok if you parse the page to get the avatar, but isnt ideal. Ideally we use the gravatar API, but that can be done in a different task. See pypi for some packages which may help.

pavi2410 commented 6 years ago

Let's start from first. What should I do? The issue doesn't describe the problem

manu-chroma commented 6 years ago

Check: https://github.com/manu-chroma/username-availability-checker/pull/72#issuecomment-356487675 https://github.com/manu-chroma/username-availability-checker/pull/72#issue-287167838

you need to fix your commit message and I think we will be able to merge then.

pavi2410 commented 6 years ago

Should I add a method to fetch gravatar image from username? If it succeeds, then return the gravatar image, else scrape the image. But we cannot guarantee that a single person has the same username in different services. For eg, if a person A has username XYZ in open hub, but the same username on gravatar is of person B.

manu-chroma commented 6 years ago

what you've done is good to go for now. just fix the commit message to include the issues you addressed. https://github.com/manu-chroma/username-availability-checker/pull/74#issuecomment-357148292

But we cannot guarantee that a single person has the same username in different services. For eg, if a person A has username XYZ in open hub, but the same username on gravatar is of person B.

that's is why we won't be doing this. integrating gravatar's from https://en.gravatar.com/ will be considered in a separate issue.