search

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
96 stars 37 forks source link

Add support for OpenHub and DeviantArt #43

Closed seeeturtle closed 6 years ago

seeeturtle commented 6 years ago

This will add checkings for OpenHub and DeviantArt. Uses icon of OpenHub from blackducksoftware/ohloh-ui repo.

Closes https://github.com/manu-chroma/username-availability-checker/issues/24

seeeturtle commented 6 years ago

Do I have to add test for this code?

manu-chroma commented 6 years ago

Do I have to add test for this code?

Yes. Refer to the existing tests. Would just be a matter of replicating the same code

manu-chroma commented 6 years ago

@seeeturtle Please rebase before proceeding further with your work.

manu-chroma commented 6 years ago

Change this line in commit: It's made because of to suppport OpenHurb. to something like Used in OpenHub testing

manu-chroma commented 6 years ago

@jayvdb any other comments?