test_username_api: Improve random username generator

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/

95 stars 37 forks source link

test_username_api: Improve random username generator #54

Closed seeeturtle closed 6 years ago

seeeturtle commented 6 years ago

This generator will generate random username that obeys username rules in websites.yml

Closes https://github.com/manu-chroma/username-availability-checker/issues/47

manu-chroma commented 6 years ago

@seeeturtle pls fix conflicts.

I'd suggest you reset your branch to latest master and redo your changes

seeeturtle commented 6 years ago

@manu-chroma fixed conflict. and can you review?

manu-chroma commented 6 years ago

@seeeturtle can you add one line doc strings for all the functions you've augmented in the tests? I think it would be really helpful for anyone making changes to the tests in future. Otherwise, there will be confusion in the same. :smile: