search

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
95 stars 37 forks source link

Set .env file to distinguish development and product #64

Closed seeeturtle closed 6 years ago

seeeturtle commented 6 years ago

This will set .env file which is for configuring host and port of backend. Also README will document this changes.

Closes https://github.com/manu-chroma/username-availability-checker/issues/30

jayvdb commented 6 years ago

Maybe look at using https://pypi.python.org/pypi/env-tools , https://pypi.python.org/pypi/env-settings or https://pypi.python.org/pypi/python-dotenv

ashwini0529 commented 6 years ago

It could be better if a parameter could be passed to distinguish the dev or prod environment. According to the parameter, it could build. For eg.: python username_api.py -dev

jayvdb commented 6 years ago

@ashwini0529 , that isnt part of the task description. .env is now a very broadly implement system. Apps creating their own mechanisms defeats the point of having a clear mechanism for setting the environment. Any interesting type of feature should be provided by the library/framework that is used. e.g. Laravel uses env var APP_ENV as an override .

jayvdb commented 6 years ago

before coala --non-interactive -V , run pip install click==6.6

manu-chroma commented 6 years ago

Set .env file to distinguish development and product Please improve this commit message.

Something like Add and use config files for setup would be better, imo