manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
95 stars 37 forks source link

Gitlab username check bug #67

Closed manu-chroma closed 6 years ago

manu-chroma commented 6 years ago

For gitlab we checking for username bytes inside the response.content from the following url: gitlab.com/<username>

when testing these two urls:

They both point to same username Rohanvdhulla but the check gives false response in the second case because we're checking for rohanvdhulla instead.

Thus, bytes('rohanvdhulla') in res.content will return false because the page contains Rohanvdhulla instead.

manu-chroma commented 6 years ago

originally reported by @Monal5031