manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
95 stars 37 forks source link

Add avatar support for Open Hub & OpenSUSE #72

Closed pavi2410 closed 6 years ago

pavi2410 commented 6 years ago

Closes #62 & #63

manu-chroma commented 6 years ago

Actually, there are a couple of issues with the PR:

pavi2410 commented 6 years ago

We cannot use gravatar unless we gain the email address of the profile

manu-chroma commented 6 years ago

but we can scrape the gravatar, given any input username.

for eg: if I enter jayvdb, we can go to en.gravatar.com/jayvdb and scrape the gravatar available there.

andrewda commented 6 years ago

@manu-chroma That's probably grounds for a whole new Gravatar website, then, right? It's not certain that the OpenHub username and the Gravatar username will be for the same individual, so it's a bit dangerous showing their icon without being sure.

pavi2410 commented 6 years ago

@manu-chroma What about this case?

image

manu-chroma commented 6 years ago

yeah, I agree we shouldn't use the same gravatar for openHub (or any other website for that matter) without knowing the email for that person.

for this PR, we can limit the scope to adding gravatar website support. Integrating it with other websites like openHub who use gravatar (via email) can be considered in a later task.

manu-chroma commented 6 years ago

The original issue was adding Gravatar support: https://github.com/manu-chroma/username-availability-checker/issues/37#issue-283084282

I think you got confused by @seeeturtle's comment

manu-chroma commented 6 years ago

actually, we can have the work you've done here in a separate PR which adds avatar for openHub

Don't force push for now. cc: @jayvdb

pavi2410 commented 6 years ago

So, I found that these sites use Gravatar:

pavi2410 commented 6 years ago

Behance is blocked in India. So I can't do anything for it

pavi2410 commented 6 years ago

I found that in case of OpenSUSE, it is not necessary that the avatar is hosted with Gravatar.

See https://connect.opensuse.org/pg/profile/Markbrmbpl https://connect.opensuse.org/mod/profile/icondirect.php?lastcache=1515405367&joindate=1515405285&guid=58076&size=large

pavi2410 commented 6 years ago

Done. Added support for OpenSUSE too by parsing method

pavi2410 commented 6 years ago

All but Behance works!

image

pavi2410 commented 6 years ago

@manu-chroma Is it fine?

seeeturtle commented 6 years ago

@pavi2410, actually asciinema also use gravatar. can you add support for asciinema? According to this comment.

for this PR, we can limit the scope to adding gravatar website support.

jayvdb commented 6 years ago

Note that these two enhancements do not Fixes #37 .

Gravatar support means checking gravatar directly, not indirectly via OpenHub.

It is very normal to have a gravatar account but not have an OpenHub account.

jayvdb commented 6 years ago

(Whoops; clicked the wrong button)

pavi2410 commented 6 years ago

Is it OK? I have tested it and it works well.

manu-chroma commented 6 years ago

can you please rebase and squash your commits?