search

manu-chroma / username-availability-checker

Live at : https://username-check.herokuapp.com/
95 stars 37 forks source link

Replace requests.get with get_with_session #86

Closed seeeturtle closed 6 years ago

seeeturtle commented 6 years ago

To get constant result, we should replace requests.get with get_with_session which returns the response of a get request sent by Session.

Closes https://github.com/manu-chroma/username-availability-checker/issues/79

manu-chroma commented 6 years ago

Failing build is due to some error in getting avatar from facebook. It is calling session.get(None) in some cases.

manu-chroma commented 6 years ago

Is normal status fetch also blocked for facebook? not considering avatar here.

because, tests for checking username status of facebook were passing on last travis build.

seeeturtle commented 6 years ago

Is normal status fetch also blocked for facebook? not considering avatar here. because, tests for checking username status of facebook were passing on last travis build.

The commit is removed.

seeeturtle commented 6 years ago

@manu-chroma , Can I merge it? Are there any problem?

manu-chroma commented 6 years ago

@seeeturtle no problem! :+1: