manu2002g / pe

0 stars 0 forks source link

No error message when invalid find command entered #2

Open manu2002g opened 2 years ago

manu2002g commented 2 years ago

To reproduce: run find k/John n/name

The error message produced is: Screenshot 2022-04-16 at 2.42.49 PM.png

There is no indication that the command actually failed. I believe this is a medium level error because most users may mistype the "f/" and be mislead into thinking the search ran successfully and returned no results.

nus-se-bot commented 2 years ago

Team's Response

This is not an invalid find command. The team has rejected this report as the reported issue is invalid. As stated in the UG, the prefixes for parameters for the find command have been clearly stated as k/ and f/ with the format of input and acceptable arguments specified. As such the above command input by the tester has been correctly parsed in by the system as searching for the keyword John n/name and since the field is not specified, the system is searching across all valid fields for all candidates for the keyword - since no candidates contain this keyword in full, the search result returns 0 candidates listed.

Further, in consideration of the fact that the character "/" could be realistically utilised in the remark field for a candidate, it would be considered suboptimal design to parse in n/ prefixes as seemingly suggested by the tester as this could be a valid part of the keyword the user is trying to search for within the remark field.

Hope this clarifies.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]