search

manu2002g / pe

0 stars 0 forks source link

Name cannot take in "s/o" #3

Open manu2002g opened 2 years ago

manu2002g commented 2 years ago

The UG specifies that name will only take in alphanumeric characters, however there is not justification provided. Given the target user profile, professors may want to document full legal names of TA applicants and will not be able to use the application if the name contains s/o.

To reproduce: add id/A0123454C n/John s/o Doe p/87633321 e/E0127756@u.nus.edu c/Computer Science yr/2 avail/1,2,3

nus-pe-bot commented 2 years ago

Team's Response

This is considered a duplicate of #1992 as both deal with the names being restricted to alpha numeric characters. This is what results in s/o not being able to be entered as a valid user input for name.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

[name validity] should names be restricted to alpha numeric only?

I think valid names can include:

  • Damith C. Rajapakse, or
  • Lee Ji-Eun

image.png

image.png

For the first instance, it can be said that "C." is abbreviated, but I'm not too sure about the 2nd case.

[original: nus-cs2103-AY2122S2/pe-interim#1978] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Our team has rejected this as not a bug reason being that in the earlier phases, we have deemed that the nature of our application does not prioritise nor necessitate the legal full name of a candidate to be inputted for functionality. The name is simply an identifier for the prof, and it is at the prof's discretion to input the name in alphanumeric format to represent and identify each candidate for the interview scheduling and for convenience. The focus is instead on the unique email, studentid and phone which identifies each unique candidate and allows for contacting the candidates.

Hope this clarifies!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Although you state that the team has decided that legal names will not be prioritised in the application there is no mention of this anywhere in the UG or DG. Since this isn't specified and the application is supposed to be a "centralised management system" for professors to recruit TAs, it is reasonable to expect the application to support full legal names.

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: I believe that the issue is a Feature Flaw because rejecting alphanumeric characters is expected behaviour according to the guide, therefore not a functionality bug.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]