search

manu354 / cryptocurrency-arbitrage

A cryptocurrency arbitrage opportunity calculator. Over 800 currencies and 50 markets.
GNU General Public License v3.0
1.21k stars 337 forks source link

Add Poloniex to official markets #1

Closed gilrosenthal closed 7 years ago

gilrosenthal commented 7 years ago

Using the Poloniex API, I added another market to the data sources with their data. I also removed them from the cryptowatch API source, so that we don't get conflicting data. Cheers!

Primly commented 7 years ago

quick question, whats the advantage over pulling data directly from Poloniex API versus relying on Cryptowatch? Thanks!

gilrosenthal commented 7 years ago

According to https://cryptowat.ch/docs/api#prices, they can be outdated by a few seconds, and if this is going to be turned into a trading bot, real-time quotes are insanely important, can't hurt to have them now!

Primly commented 7 years ago

I was thinking it must be something like that...good choice!

manu354 commented 7 years ago

Thanks :) Code looks perfect! Will merge now.

manu354 commented 7 years ago

Just looked at the results from poloniex and realised that cryptowatch didn't list all of the coins available on poloniex so it was actually very good to use its own API. I will try do this for all the coins listed on cryptowatch and stop using the cryptowatch API.

artursapek commented 7 years ago

@gilrosenthal @Primly the cryptowatch API is only a few sec out of date on the aggregate endpoint https://api.cryptowat.ch/markets/prices. Any market specific endpoint like https://api.cryptowat.ch/markets/poloniex/ethbtc/price is updated in real time.