manu354 / cryptocurrency-arbitrage

A cryptocurrency arbitrage opportunity calculator. Over 800 currencies and 50 markets.
GNU General Public License v3.0
1.19k stars 336 forks source link

Add gitignore and move socket.io to local #7

Closed gilrosenthal closed 7 years ago

gilrosenthal commented 7 years ago

Should improve load times and also make contributing easier

manu354 commented 7 years ago

I wanted to do this but wasn't sure how to. The GitHub pages is hosted based off that document and if you make it connect to a local socket.io it won't work. Needs some type of if else statement to catch an error if error using local use the hosted socket.io

manu354 commented 7 years ago

Oh jokes it's just the socket.io library. I thought it was pulling a custom JS file everytime. What I said above was about initialising the socket.io() in the script.js

manu354 commented 7 years ago

Thanks, going to merge but still need to find a way to use local data for debugging unless without messing up with the hosted version.