search

manu7irl / klipper-DWC2-installer

to streamline the install or upgrade of KLIPPER & DWC2 front-end for it. With these 2 together no need to use octoprint. I run mine on orangepi zero with H2+ CPU 512MB and it works nicely.
GNU General Public License v3.0
54 stars 13 forks source link

BUG: typo in installer for webcam #15

Open Googliola opened 3 years ago

Googliola commented 3 years ago

https://github.com/manu7irl/klipper-DWC2-installer/blob/21ebac9067bad34b480988e4d2639ffcad987ab8/installer.sh#L755 it should say MJPGSTREAMER_HOME=$installLocation/mjpg-streamer/mjpg-streamer-experimental

Minor: https://github.com/manu7irl/klipper-DWC2-installer/blob/21ebac9067bad34b480988e4d2639ffcad987ab8/install-multisession-octoprint.sh#L175 b is missing in bak directory: webcamDaemon_bak

manu7irl commented 3 years ago

Hi thanks for noticing it... This script alone has been deprecated for long... As I run all the function from on main script. I have still a lot to do to improve what we have from now especially the octoprint installer part...

On Fri, Sep 4, 2020, 9:27 AM Googliola notifications@github.com wrote:

https://github.com/manu7irl/klipper-DWC2-installer/blob/21ebac9067bad34b480988e4d2639ffcad987ab8/installer.sh#L755 it should say MJPGSTREAMER_HOME=$installLocation/mjpg-streamer/mjpg-streamer-experimental

Minor:

https://github.com/manu7irl/klipper-DWC2-installer/blob/21ebac9067bad34b480988e4d2639ffcad987ab8/install-multisession-octoprint.sh#L175 b is missing in bak directory: webcamDaemon_bak

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/manu7irl/klipper-DWC2-installer/issues/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWT4RBTAD23KA2JNKRQEYDSECCDXANCNFSM4QXMFVUA .

Googliola commented 3 years ago

As I run all the function from on main script. What is the main script? If you are referring to klipper-DWC2-installer/installer.sh then see my first note, otherwise, I don't know what you mean by that.

As for my installation, I managed to get 2 instances of klipper & DWC up and running thanks to your script, but octoprint and webcam have failed so far. Good thing is that this installation might help me configure my regular octopi & klipper & DWC combo - the latter never seems to work and webcam, well I save that for another rainy day ;-)

Anyway, your script is really nice, my favourite being the multiple session thingie and haproxy. Maybe I will attempt the same some day and study your scripts for that matter.

There is one last thing I urge you to do: Add a note in your readme that your project is very much a work in progress and not suited for the faint-hearted / less linux savy But by all means, continue to develop it, I think it has great value and the potential to spare lots of headaches! Especially for beginners / intermediates.