search

manubot / rootstock

Clone me to create your Manubot manuscript
https://manubot.github.io/rootstock/
Other
453 stars 178 forks source link

AI Editor: add example config files #512

Closed miltondp closed 4 months ago

AppVeyorBot commented 4 months ago

AppVeyor build 1.0.339 for commit 33e2bdff4cf111f4f088d1bfdcdf61fc395b0030 is now complete.

Found 51 potential spelling error(s). Preview:content/02.delete-me.md:44:adipiscing content/02.delete-me.md:44:aliqua content/02.delete-me.md:44:amet content/02.delete-me.md:44:consectetur content/02.delete-me.md:44:dolore content/02.delete-me.md:44:eiusmod content/02.delete-me.md:44:elit content/02.delete-me.md:44:incididunt content/02.delete-me.md:44:ipsum content/02.delete-me.md:44:labore content/02.delete-me.md:44:Lorem content/02.delete-me.md:44:magna content/02...
The rendered manuscript from this build is temporarily available for download at:

miltondp commented 4 months ago

@dhimmel this PR is ready to be merged. @vincerubinetti maybe you can start testing this now.

vincerubinetti commented 4 months ago

@dhimmel note that doing a fresh fork of rootstock failed (for the ai editor) because the manubot package is specified as a specific commit rather than a semver or github@latest version. That will be need to be updated as well. It also seems like a new PIPY version should be pushed, and that rootstock should be based off of PYPI, but I'll leave that to you.

miltondp commented 3 months ago

@dhimmel note that doing a fresh fork of rootstock failed (for the ai editor) because the manubot package is specified as a specific commit rather than a semver or github@latest version. That will be need to be updated as well. It also seems like a new PIPY version should be pushed, and that rootstock should be based off of PYPI, but I'll leave that to you.

From this, I understand that following the instructions to create a new Manubot-based manuscript (fork of this repo) and run the AI Editor would fail, right?

dhimmel commented 3 months ago

note that doing a fresh fork of rootstock failed (for the ai editor) because the manubot package is specified as a specific commit rather than a semver or github@latest version.

This pull request should have incremented the manubot version for manubot ai-revision --config-directory support. My bad for not noting that during the review.

https://github.com/manubot/rootstock/pull/513 upgrades the manubot version used in rootstock and should resolve the problem.

I see the following as separate points as separate from the cause of this issue (and separate from eachother):