manucontrovento / SpinTool

Loop application synced with jack transport
GNU General Public License v3.0
13 stars 2 forks source link

Appearence with Breeze Dark theme #1

Closed Houston4444 closed 4 years ago

Houston4444 commented 4 years ago

Hi. You will see below how your software looks on KDE with Breeze Dark Theme. I think I don't have to talk too much, the screenshot talks itself !

superboucle

I didn't take time to test the software for the moment, I saw you renamed it, good point !

manucontrovento commented 4 years ago

wow! a bit messy :) I'll try to find the way to make the graphics not affected by theme. Thanks!

manucontrovento commented 4 years ago

Hi @Houston4444 maybe I found the solution; I'll include it in next release, among other improvements

Houston4444 commented 4 years ago

Are the modifications made on master branch ? If it is the case, I can quickly test the master branch.

manucontrovento commented 4 years ago

Yes you could; but first you'll have to download the release of the "new" software (with the new name) or to download the whole master branch, which I updated after renaming the application, since following application name I changed all namespaces.

After dowloading current master branch or release, unpack in \spintool directory overwriting exhisting files:

update_for_styles.zip

manucontrovento commented 4 years ago

Hi @Houston4444

please try with new release:

https://github.com/manucontrovento/SpinTool/releases/tag/v20.04.13

and let me know

Houston4444 commented 4 years ago

Hi.

Different but not really better ! PS: ./Spintool.sh needs a chmod +x

Screenshot_20200413_180942

manucontrovento commented 4 years ago

Hi! I don't know what to say, I thought that forcing stylesheets for all widgets (in previous version there were no stylesheets) would have forced the appearence to look as I see it. It seems that the os theme affects the appearence overriding the stylesheets settings and at the moment I don't know how to change it.. I'll search on some forum.

Did you download new version and completely delete all files of the previous one?

Houston4444 commented 4 years ago

This is with the new version (and there were no files remaining because of the name change). Something else, console output says this multiple times (without doing anything).

Traceback (most recent call last): File "/home/houston/codes_sources/SpinTool-20.04.13/superboucle/gui.py", line 609, in onBeatOffsetChange self.last_clip.beat_offset = self.beat_offset.value() AttributeError: 'NoneType' object has no attribute 'beat_offset'

Wait, this is python Qt, so I know well this, I'll take a look.

manucontrovento commented 4 years ago

Ok, interesting, I'll have a look at it. It's strange because in my console I don't see that message. It's something I want to understand, however I don't think it's the reason of the strange appearence Meanwhile I asked for some help in a forum, I'm quite sure that someone else has faced the same problem.

sonejostudios commented 4 years ago

@Houston4444 Just a question: Is this also happening with the original SuperBoucle from Vampouille?

Houston4444 commented 4 years ago

Sorry, I made a mistake. This message appears applying mouse wheel on the Beat amount spinBox . In SuperBoucle, this groupBox is not Enabled.

sonejostudios commented 4 years ago

@Houston4444 . Sorry to have been not precise enough...my question was, Is the whole dark theme problem also in original SuperBoucle from Vampouille? (but good to know the beat amount spinbox problem is new! ;) )

manucontrovento commented 4 years ago

Sorry, I made a mistake. This message appears applying mouse wheel on the Beat amount spinBox . In SuperBoucle, this groupBox is not Enabled.

Ok! Thanks! I will fix it!

Houston4444 commented 4 years ago

@sonejostudios, no appearance problem in SuperBoucle. Note I did test the last SuperBoucle release, not the master.

manucontrovento commented 4 years ago

It's true that it's my first time dealing with Qt, but I'm a bit confused about stylesheets... what's the use of defining them, if changing a theme it still affects the widgets?... there must be something obvious that I'm not catching

sonejostudios commented 4 years ago

This is interesting... if the problem was not in SB Master, what did you change @manucontrovento in the GUI so the proplem appears? Maybe just go back to the original theme? How did you change the gui, with QtDesigner or programmatically?

manucontrovento commented 4 years ago

I really can't reply to these questions.. because I don't know! I didn't intentionally change any theme.. I even didn't know that the application could have a theme. With Qt Designer I made my changes to the UI, and then when @Houston4444 reported me the problem, I assigned styilesheet to every UI element (window included) to be sure that they would appear as I decided.

sonejostudios commented 4 years ago

This is really weird because it should be the same on SB Master... @manucontrovento did you try to force the Qt Style?

manucontrovento commented 4 years ago

@sonejostudios if you mean the code you sent me, I'll try next days :)

sonejostudios commented 4 years ago

yes, this code! ;)

manucontrovento commented 4 years ago

Hi @Houston4444
try downloading new spin.py module:

https://github.com/manucontrovento/SpinTool/blob/master/superboucle/spin.py

thanks to @sonejostudios I found the way to force the theme. I realized I was wrong on how Qt manages its appearence. Maybe when SB was developed, system Qt theme was gtk2. So, its "real" appearence needs to be that theme. Now on starting, gtk2 theme is applied.

manucontrovento commented 4 years ago

Hi @Houston4444 did you try the changes? It's included in latest release too. If you don't see the problem anymore we can close the issue

Houston4444 commented 4 years ago

Sorry no, it's exactly the same. But as I run KDE Neon, I have always the last KDE version, and now I don't find anymore the GTK appearence configuration, I don't know what they have made, it can't be strange.

manucontrovento commented 4 years ago

Ok, now I understand! to properly work, Gtk theme is required. So first of all I should write it into prerequisites, since I don't see any other possible solution. Or maybe I should find the way to download and install the theme along with other dependencies and requirements

manucontrovento commented 4 years ago

Hi, could we close the issue? did you try with gtk theme?

manucontrovento commented 4 years ago

Not getting any news I close the issue, if there will still be problems even with gtk theme present, we'll re-open the issue.