search

manuel-calzolari / sklearn-genetic

Genetic feature selection module for scikit-learn
https://sklearn-genetic.readthedocs.io
GNU Lesser General Public License v3.0
324 stars 77 forks source link

Replace np.bool with Python bool for numpy 1.20 #40

Closed musicinmybrain closed 1 year ago

musicinmybrain commented 1 year ago

The np.bool type was just an alias for Python bool, and was removed in numpy 1.20.

Fixes #39; fixes compatibility with numpy 1.20 and later, without breaking compatibility with other versions.

https://numpy.org/devdocs/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated

detrin commented 1 year ago

@musicinmybrain please close your PR, this will be solved also in my PR https://github.com/manuel-calzolari/sklearn-genetic/pull/41 with other stuff

musicinmybrain commented 1 year ago

Closing at @detrin’s request.