manuel-serrano / bigloo

a practical Scheme compiler
http://www-sop.inria.fr/indes/fp/Bigloo
Other
133 stars 20 forks source link

Extend IPv6 support in the sockets api #81

Closed donaldsonjw closed 1 year ago

donaldsonjw commented 2 years ago

make-client-socket and make-server-socket now both accept a domain keyword argument specifying the address family for the resulting socket. By default, domain is 'inet (i.e., IPv4) but can also be 'inet6 (i.e., IPv6), 'unix, or 'local. This necessitated extending make-server-socket to support unix sockets. The required file path is provided in the name keyword argument.

The make-datagram-server-socket, make-datagram-unbound-socket, and make-datagram-client-socket were similarly extended with an optional domain argument, default value 'inet. Minor bugs were fixed in make-datagram-client-socket.

Finally, make-ssl-client-socket and make-ssl-server-socket were also modified to have a domain keyword argument specifying the address family. The default value is 'inet. This is passed on to the corresponding make-client-socket and make-server-socket calls.

manuel-serrano commented 1 year ago

Hi Joe,

I should have merged the PR earlier but now I'm a little bit afraid of merging it so close to a release date. I then propose to merge it right after 4.5a is released. It will be include for 4.5b. Sorry for the delay, in particular because it is a very valuable addition to the socket api.

-- Manuel

donaldsonjw commented 1 year ago

That sounds good. I agree having more time to identity and fix any problems with the changes is a good idea