manuelVo / foundryvtt-drag-ruler

A Foundry VTT module that shows a ruler when dragging tokens so you can see how far you've dragged them
MIT License
39 stars 52 forks source link

Potential conflict with Inactive Tokens #252

Open txm3278 opened 1 year ago

txm3278 commented 1 year ago

This warning is logged when moving any token image

kiligir commented 1 year ago

Came to leave the same conflict.

[W] libWrapper: Potential conflict detected between module Drag Ruler and module Inactive Tokens.
Module drag-ruler did not chain the wrapper for 'Token.prototype._onDragLeftDrop'. libWrapper-notifications.js:89:5.
manuelVo commented 1 year ago

Are you experiencing any actual conflict between the modules?

txm3278 commented 1 year ago

Sometimes when an active token is on top of an inactive token I can't move the active token. I'm not sure if this warning is what's causing that or if it's something else entirely.

manuelVo commented 1 year ago

Sorry for the late response. Are you still experiencing that issue? If so, does the issue go away if you Drag Ruler?

txm3278 commented 1 year ago

Sorry for the very late response, I forgot about this until recently testing v11. I don't notice any actual conflict between the modules. The warning does pop up as an overlay on screen every time I move a token for the first time on load so it would be nice if there was a way to fix this but not urgent at all.

manuelVo commented 1 year ago

Libwrapper is a bit overzealous when showing warnings to users. Getting such a warning is no indication that there are two modules that mod the same portion of foundry (dragging tokens in this case). In that case it shows a warning that there may or may not be a conflict (which is the warning you're getting). You can disable those warnings in the libwrapper settings by disabling "Notify GM of issues". However this has the downside that if you disable that checkbox you won't be notified of actual issues anymore either.