search

manuelVo / foundryvtt-drag-ruler

A Foundry VTT module that shows a ruler when dragging tokens so you can see how far you've dragged them
MIT License
39 stars 52 forks source link

initial support for V11 #275

Closed pkonshik closed 1 year ago

pkonshik commented 1 year ago

Probably it should go to the specific branch & specific release

mclemente commented 1 year ago

Gotta delete token.mouseInteractionManager._deactivateDragEvents(); on ruler.js to remove an error when right-click to cancel, the method became private.

Everything else seems to be just deprecation warnings.

Txus5012 commented 1 year ago

Deleting that line creates more issues than it solves.

Sent a PR to this PR (is this the right way to do this?) to solve an error with waypoints and remove the deprecation warnings. Also took the chance to add the default values for WFRP 4e.

manuelVo commented 1 year ago

@Txus5012 please put the default values for WFRP 4e into a separate PR. Two smaller PRs are far easier to review and merge than one bigger PR. Thanks :)

manuelVo commented 1 year ago

Closing in Favor of #277