manuelVo / foundryvtt-drag-ruler

A Foundry VTT module that shows a ruler when dragging tokens so you can see how far you've dragged them
MIT License
40 stars 52 forks source link

Fix for label not always showing + distance calculation wrong for diagonals #343

Open Valerionn opened 3 weeks ago

Valerionn commented 3 weeks ago

This PR fixes two issues:

Additionally, I've updated some calls so that no more deprecation warnings get printed when dragging the ruler (except when routinglib is active).

If you need some small adjustments, just tell me - but overall the Foundry development experiment with the de-facto non-existing developer documentation didn't really encourage me to do more testing than "this works in exactly my case and that's good enough for me".

AshnakAGQ commented 2 weeks ago

@manuelVo Please pull. this issue is annoying.

smeeth123 commented 6 days ago

Please pull. Pythagoras is rolling over in his grave.

SilvesTheRog commented 5 days ago

@manuelVo Please pull

Valerionn commented 5 days ago

@AshnakAGQ @smeeth123 @SilvesTheRog I've made my fork available for install until this PR is merged. You can install it by clicking on "Install Module" in Foundry and then manually copy/paste the following Manifest URL in the input field at the bottom:

https://raw.githubusercontent.com/Valerionn/foundryvtt-drag-ruler/master/module.json

This should replace your drag ruler version. If everything went right, you should see a module named "Drag Ruler [Fork - Valerionn]" with version "1.14.2f": dragrulerfork

This should work completely out-of-the box but feel free to create an issue over at https://github.com/Valerionn/foundryvtt-drag-ruler if something doesn't work (though I can't promise support for all issues since I didn't create the module and just changed some small things).

I will update the manifest as soon as the original module here is updated so that you will automatically switch back to the original module when you update (but you can also always re-install the original package which should replace the fork).

Also, please remember that people develop these foundry modules for fun in their free time, so please don't spam the PR, I'm sure they'll look at it and merge it as soon as they have time & energy for this (even though I can understand that this issue is really annoying).