search

manuelVo / foundryvtt-routinglib

A Foundry VTT library that allows other modules perform pathfinding within the scene
MIT License
3 stars 7 forks source link

v12 deprecation warnings #22

Open ddbrown30 opened 4 months ago

ddbrown30 commented 4 months ago

canvas.grid.isHex is deprecated. Use of canvas.grid.isHexagonal instead. BaseGrid#w is deprecated in favor of BaseGrid#sizeX. BaseGrid#h is deprecated in favor of BaseGrid#sizeY.

Screenshot 2024-07-05 130537 Screenshot 2024-07-05 130521 Screenshot 2024-07-05 130528

ottyn commented 3 months ago

+1 on this for FVTT 12 support

manuelVo commented 3 months ago

The indicated warnings should not cause any issues. Those are only a warning that things need to be changed for foundry 14 compatibility. Are there any noticeable issues with routinglib?

ottyn commented 3 months ago

The indicated warnings should not cause any issues. Those are only a warning that things need to be changed for foundry 14 compatibility. Are there any noticeable issues with routinglib?

While the warnings themselves don't cause any issues, the constant console spam every time a token is moved can get quite annoying. A short 30 minute combat testing session in my test world generated 500+ warning messages in the console just from the Witch character with her familiar token riding on her and from the Summoner/Eidolon characters set to follow. Both are done using the Ridable module which uses Routinglib.

I haven't seen any issues arise where the module is not working so far though.

IHaveThatPower commented 2 weeks ago

Submitted a pull request that I think covers (most of) these: https://github.com/manuelVo/foundryvtt-routinglib/pull/25