fix: make native ESM importing from Node.js work

manuelbieh / geolib

Zero dependency library to provide some basic geo functions

MIT License

4.23k stars 342 forks source link

fix: make native ESM importing from Node.js work #272

Closed LinusU closed 3 years ago

LinusU commented 3 years ago

This is a backwards compatible patch to make importing from Node.js in native ESM mode work. The reason this adds all of the files as valid import targets is to make sure that any import that worked before still works now.

LinusU commented 3 years ago

error An unexpected error occurred: "Failed to replace env in config: ${NPM_TOKEN}".

@manuelbieh as far as I can tell the CI-failure is not related to my changes? 🤔

LinusU commented 3 years ago

ping @manuelbieh any chance of landing this?

manuelbieh commented 3 years ago

Hey, yeah. Sorry, I'm not actively using the library in any of my current projects anymore so I muted all notifications 🙈 I will try to catch up on all reported issues and pull requests in the upcoming weeks.

The CI error is a bit weird. I have no idea why it doesn't work anymore. I will check and once the CI passes again, I will merge this one!

LinusU commented 3 years ago

Thanks!

Let me know if you want help with anything else, e.g. I could submit a PR to switch to Github Actions if you want to (I have no experience debugging CircleCI, but do have with Github Actions)

manuelbieh commented 3 years ago

I still have no idea why CI fails. The allegedly missing NPM_TOKEN exists in CircleCI it's just not populated during build. Who knows why?! I now merged it anyway. Let's hope for the best 😄

Thanks for your contribution!

manuelbieh commented 3 years ago

Looks like this was the reason:

manuelbieh commented 3 years ago

:tada: This PR is included in version 3.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: