manuelbl / ttn-esp32

The Things Network device library for ESP32 (ESP-IDF) and SX127x based devices
MIT License
303 stars 64 forks source link

Problems getting hello_world running on ESP-IDF 4.0 #14

Closed zdila closed 3 years ago

zdila commented 4 years ago

For ESP-IDF I had to perform following changes for hello_world example to compile:

Thanks for awesome library!

manuelbl commented 4 years ago

Thanks for the info.

Most likely I will not upgrade the library to ESP-IDF 4.0 until it's officially released. But with your changes, anyone can upgrade earlier.

zdila commented 4 years ago

Maybe a macro could be used now:

#if IDF_MAJOR_VER >= 4
#include <freertos/semphr.h>
#endif
#if IDF_MAJOR_VER >= 4
#include "driver/gpio.h"
#endif
manuelbl commented 4 years ago

ESP-IDF 4.0 is not stable yet. So any such code change might not work anymore with later development releases or with the final 4.0 release. I'm very reluctant to implement it.

zdila commented 4 years ago

OK, no problem, just giving some hints ;-)

manuelbl commented 4 years ago

The dev branch now contains a major update to the library including compatibility with the upcoming version 4 of ESP-IDF.

manuelbl commented 3 years ago

Release 3.2.0 is has been released and is based on ESP-IDF 4.0.x