Closed mkfrey closed 2 years ago
Thanks for the PR. Both issues should be fixed.
However, I cannot reproduce the problem, with neither ESP-IDF 4.3.2 nor with 4.4. Did this occur with one of the sample projects such as hello_world? Did you use any special settings?
I am using custom code without any special settings. But I've changed so much of it today that I'm no longer able to reproduce the issue as well. But I know that a full clean didn't solve the problem. Maybe I accidentally used esp-idf master.
Nonetheless, driver/gpio.h
already contains a warning stating that the inclusion of rom/gpio.h
will be removed on next release and that esp_rom_gpio.h
is the way to go forward.
I agree that it needs to be changed.
However instead of replacing gpio_pad_select_gpio()
with the even more low-level esp_rom_gpio_pad_select_gpio()
function, I will replace it with gpio_reset_pin()
, pending some testing.
Sounds like a good idea. I was already wondering why such a low level call that I've personally never encountered is even needed.
esp_rom_gpio_pad_select_gpio()
is btw. just an alias to gpio_pad_select_gpio()
, so I'ts not really more low level. I think espressif just wants to make it more clear that this isn't an ordinary gpio_*
function.
I've checked again, and it looks like I was accidentally using esp-idf master. So my commits would fix the build on master.
Thanks a lot. I've merged your PR with the additional discussed changes.
When compiling as component of ESP-IDF v4.3.2 I got the following compilation errors:
This PR fixes both of them.