search

manuelbl / ttn-esp32

The Things Network device library for ESP32 (ESP-IDF) and SX127x based devices
MIT License
301 stars 64 forks source link

fix compilation issues against esp-idf v5.1-dev-187-g5b11895700 #57

Closed ohnowhathaveidone closed 1 year ago

ohnowhathaveidone commented 1 year ago

hi,

thanks for providing this component! got me up and running within a day! i appreciate your work.

i had problems compiling the component against esp-idf v5.1-dev-187-g5b11895700 - i added ttn-esp32 to the global components folder in my main esp-idf directory. this was tested on kubuntu 22.04.1. i'll probably test on another OS soon.

i may have butchered things here or gotten them wrong, but the changes seem to have resolved the issues for me :)

cheers!

ohnowhathaveidone commented 1 year ago

the patches also work on endeavourOS, against esp-idf v5.1-dev-862-g09f7589ef2

manuelbl commented 1 year ago

Thank you very much. I had to make an additional change in order not to break it with ESP-IDF v4.x.

I've only tested it with beta 1 of v5.0. The fix works and is mandatory for that release as well.

ohnowhathaveidone commented 1 year ago

thank you! i just realized that was using a dev branch of esp-idf and that 4.x was still the stable release. i hope this won't break anything in the future.

cheers!