search

manuelbl / ttn-esp32

The Things Network device library for ESP32 (ESP-IDF) and SX127x based devices
MIT License
308 stars 64 forks source link

KR921 Frequency Plan #7

Closed pctj101 closed 4 years ago

pctj101 commented 5 years ago

This is what I have so far in trying to match with the following frequency plan for TTN: https://account.thethingsnetwork.org/api/v2/frequency-plans/KR_920_923

Not sure what copyright notices should be applied to the "new" files based on "existing" files.

For many of the "magic numbers", made my best guess.

Looks like KR921 doesn't have FSK, so I took that out. https://www.thethingsnetwork.org/docs/lorawan/frequency-plans.html#kr920-923

Verified operation of LoRa Node -> LoRa Gateway with Join/Uplink/Downlink operation on TTN with Gateway using KR_920_923 as stated above.

manuelbl commented 5 years ago

Thanks a lot for your contribution.

As this library is based on MCCI's Arduino LMIC library, I'd prefer if the Korean frequency plan was part of their library. Otherwise it will be difficult to keep up with the bug fixes and enhancement in that library.

Can you also create a pull request for mcci-catena/arduino-lmic?

pctj101 commented 5 years ago

Sure I'll take a look and see if they're interested.

terrillmoore commented 5 years ago

I'm the maintainer of https://github.com/mcci-catena/arduino-lmic; would be happy to have a pull request.

manuelbl commented 4 years ago

The dev branch now contains the latest version of the MCCI-Catena LMIC library that includes the frequency plan for South Korea. So if you don't mind, I'm going to close this pull request.