search

manuelluis / jsrrdgraph

javascript rrdgraph
61 stars 12 forks source link

Typo, Lib update for IE11, Better Default Fonts #9

Closed Poil closed 9 years ago

manuelluis commented 9 years ago

The fix for textalign if commited: c735da8f06fdaf3a03186272b80be24490d008ef

The other changes in javascriptRRD broke something and some test are not working.

About the fonts: the idea of ​​doing this "port" to javascript is that the result is as close as possible to rrdtool. The default font in rrdtool, as far as I know, is "DejaVu Sans Mono", so I maintain this font.

manuelluis commented 9 years ago

Merged javascriptrrd version 1.1.1 2a74a333ff143499b465234f0395a4aad7bdaa78

Poil commented 9 years ago

"About the fonts: the idea of ​​doing this "port" to javascript is that the result is as close as possible to rrdtool." :

Yep but when you don't have DejaVu, on Windows it does not use a "monospaced font", this is working and keep as close as possible as native rrdtool :

this.DEFAULT_FONT = "'DejaVu Sans Mono', 'Courier', 'Ubuntu Mono'";

And you also need this fix https://github.com/Poil/jsrrdgraph/commit/2ec1d4d118a7d184076ff4784715976a71c5aef1

manuelluis commented 9 years ago

Done.

Thank you.