search

manuelmhtr / countries-and-timezones

Minimalistic library to work with countries and timezones data
MIT License
224 stars 67 forks source link

Outdated DST offset for Asia/Famagusta timezone #19

Closed sofiafrocha closed 4 years ago

sofiafrocha commented 4 years ago

(First, thank you for your work on this package!)

Currently, the Asia/Famagusta timezone has the following data:

{
    name: "Asia/Famagusta",
    aliasOf: null,
    country: "CY",
    dstOffset: 120,
    dstOffsetStr: "+02:00",
    utcOffset: 120,
    utcOffsetStr: "+02:00"
}

Which indicates that the timezone does not observe DST.
However, this is no longer the case, as now both Asia/Famagusta and Asia/Nicosia observe DST. So the timezones should return the same UTC (120) and DST (180) offsets.

The ICANN mailling list and ICANN data (search for "# Cyprus") has more context around the changes and links for news reports related to the change.

manuelmhtr commented 4 years ago

Hello @sofiafrocha :) thanks for noticing this issue. I'll fix it as soon as possible.

manuelmhtr commented 4 years ago

Hi @sofiafrocha, the fix for "Asia/Famagusta" is now available in v2.2.0. Along with other 17 timezones updated and 89 added (it now complies with the IANA timezones database. Happy coding 😄

sofiafrocha commented 4 years ago

Awesome, thank you! 😀😀