search

manuelmhtr / countries-and-timezones

Minimalistic library to work with countries and timezones data
MIT License
224 stars 67 forks source link

extends lib with country code iso3 #33

Closed nvs2394 closed 3 years ago

nvs2394 commented 3 years ago

Follow country code standards. We have 2 types of country codes.

So just extend this lib can return with both 2 chars and 3 chars.

3 chars data get from countries-db

manuelmhtr commented 3 years ago

Hi @nvs2394 I really appreciate your contribution. However, one of the main objectives of this library is to be as simple and lightweight as possible.

Depending on the application some devs might require the ISO3 code, phone prefix, continent, domain, emoji or other properties of a country; but how can we decide whether to include another property or not? That's why I created countries-db as a separated project.

I'm sorry I'm not able to merge this PR, but I think the best is to keep this project simple and keep countries-db for devs requiring more data.