search

manuelroemer / Nullable

A source code only package which allows you to use .NET's nullable attributes in older target frameworks like .NET Standard 2.0 or the "old" .NET Framework.
https://www.nuget.org/packages/Nullable
MIT License
184 stars 8 forks source link

Use #pragma warning restore instead of #pragma warning enable #10

Closed manuelroemer closed 4 years ago

manuelroemer commented 4 years ago

While this is most likely not going to cause problems, it is good practice to use #pragma warning restore instead of #pragma warning enable. In the nullable files, enable is used at the moment: https://github.com/manuelroemer/Nullable/blob/a39a33ce09afa8c2ea75ba3d642973e06ef129fa/src/Nullable.ExcludeFromCodeCoverage/NullableAttributes.cs#L314

This was an oversight and should be changed. If there are no complaints/problems due to this in the meantime, I will delay the fix until the next release of the package.

manuelroemer commented 4 years ago

Will be available in 1.3.0.